Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Exclude Committer Checklist section from commit message #4202

Closed
wants to merge 1 commit into from
Closed

MINOR: Exclude Committer Checklist section from commit message #4202

wants to merge 1 commit into from

Conversation

ijuma
Copy link
Member

@ijuma ijuma commented Nov 10, 2017 •
edited
Loading

It seems like it's sufficient to be able to refer to it in the PR.

Committer Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma force-pushed the exclude-committer-checklist-when-merging branch 2 times, most recently from 1267832 to fd91e98 Compare November 10, 2017 11:58
@ijuma
Copy link
Member Author

ijuma commented Nov 10, 2017 •
edited
Loading

@rajinisivaram, can you please review? I tested with this PR with no additional text and it looks like:

    MINOR: Exclude Committer Checklist section from commit message

    Author: Ismael Juma <[email protected]>

    Reviewers: (excluded from commit message)

    Closes #4202 from ijuma/exclude-committer-checklist-when-merging

After adding the text:

    MINOR: Exclude Committer Checklist section from commit message

    It seems like it's sufficient to be able to refer to it in the PR.

    Author: Ismael Juma <[email protected]>

    Reviewers: Rajini Sivaram <[email protected]>

    Closes #4202 from ijuma/exclude-committer-checklist-when-merging

@rajinisivaram
Copy link
Contributor

If I am seeing this for the first time, it is difficult to know that the text before Committer Checklist appears in the commit message. Could we have a note at the end of that checklist for the author of the PR?

@ijuma ijuma force-pushed the exclude-committer-checklist-when-merging branch from fd91e98 to 63fe011 Compare November 10, 2017 12:25
rajinisivaram
rajinisivaram approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@rajinisivaram rajinisivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, the note already in the PR template is sufficient.

Thanks for the PR, LGTM.

@asfgit asfgit closed this in d04daf5 Nov 10, 2017
@ijuma ijuma deleted the exclude-committer-checklist-when-merging branch December 22, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajinisivaram rajinisivaram rajinisivaram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijuma @rajinisivaram