MINOR: Consistent terminal period in Errors.defaultExceptionMessage #3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombentley
force-pushed
the
MINOR-Errors-punctuation
branch
from
ebdaca4 to
bb3f671
Compare
|
@mimaison any chance you could reivew this one? It's trivial. |
|
@mimaison This caused a failure in |
3 tasks
|
@hachikuji My bad. I'll make sure I always run tests. |
|
@hachikuji also my bad, sorry. According to https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes "The Jenkins automatic pull request builder will run unit and integration tests on your branch", I guess that's no longer true, and if I want to run the tests on Jenkins I need to request it specifically, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some default messages ended with a period and some didn't, so make things consistent.
The contribution is my original work and I license the work to the project under the project's open source license.