KAFKA-4501: Java 9 compilation and runtime fixes #3647
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
ijuma
force-pushed
the
kafka-4501-support-java-9
branch
from
1fca2f0
to
2e92b1d
Compare
ijuma
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
|
Review by @hachikuji. |
|
Refer to this link for build results (access rights to CI server needed): |
ijuma
force-pushed
the
kafka-4501-support-java-9
branch
from
57ce4e9
to
910a050
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
@hachikuji, https://builds.apache.org/job/kafka-trunk-jdk9/1/console shows that the build compiles with Java 9, but EasyMock/PowerMock tests fail. |
| @@ -269,8 +270,8 @@ object LogConfig { | |||
| */ | |||
| def fromProps(defaults: java.util.Map[_ <: Object, _ <: Object], overrides: Properties): LogConfig = { | |||
| val props = new Properties() | |||
| props.putAll(defaults) | |||
| props.putAll(overrides) | |||
| defaults.asScala.foreach { case (k, v) => props.put(k, v) } | |||
There was a problem hiding this comment.
Curious why you didn't add another implicit ++= for this?
There was a problem hiding this comment.
The key type is Object instead of String, which is unsafe. We should probably change the type of the map received by LogConfig but I didn't want to tackle that here.
| protected ScramSaslClientProvider() { | ||
| super("SASL/SCRAM Client Provider", 1.0, "SASL/SCRAM Client Provider for Kafka"); | ||
| for (ScramMechanism mechanism : ScramMechanism.values()) | ||
| super.put("SaslClientFactory." + mechanism.mechanismName(), ScramSaslClientFactory.class.getName()); | ||
| put("SaslClientFactory." + mechanism.mechanismName(), ScramSaslClientFactory.class.getName()); |
There was a problem hiding this comment.
The super qualifier didn't achieve anything.
| } | ||
| URL_ENCODE_NO_PADDING = encode.bindTo(juUrlEncoderNoPassing); | ||
|
|
||
|
|
There was a problem hiding this comment.
Unintentional, will fix.
ijuma
force-pushed
the
kafka-4501-support-java-9
branch
from
910a050
to
e65323a
Compare
|
Fixed the empty lines, merging to trunk. |
Compilation error fixes:
code (Ambiguous reference when invoking Properties.putAll() in Java 11 scala/bug#10418)
Ambiguous reference when invoking Properties.putAll() in Java 11 scala/bug#10418 (comment))
Java 9 support findbugsproject/findbugs#105)
Compilation warning fixes:
Runtime error fixes:
Also:
Note that tests involving EasyMock (easymock/easymock#193)
or PowerMock (powermock/powermock#783)
will fail as neither supports Java 9 currently.