MINOR: Fix newlines not working in LISTENERS_DOC #18388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
| " <code>CLIENT://0.0.0.0:9092,REPLICATION://localhost:9093</code>%n" + | ||
| " <code>PLAINTEXT://127.0.0.1:9092,SSL://[::1]:9092</code>%n"; | ||
| public static final String LISTENERS_DOC = String.format("Listener List - Comma-separated list of URIs we will listen on and the listener names." + | ||
| " If the listener name is not a security protocol, <code>%1$1s</code> must also be set.%n" + |
There was a problem hiding this comment.
Why using %1$1s? Change to %s can fix the issue on my laptop.
There was a problem hiding this comment.
You are right.
Use %s can work on it.
I fixed it.
Thank you for your comment.
clarkwtc
force-pushed
the
minor-fix-newline-not-working-in-listeners-doc
branch
from
4167d58 to
1431d45
Compare
FrankYang0529
approved these changes
Jan 5, 2025
m1a2st
reviewed
Jan 5, 2025
Comment on lines
70
to
71
| " Listener names and port numbers must be unique unless %n" + | ||
| " one listener is an IPv4 address and the other listener is %n" + |
There was a problem hiding this comment.
nit This seems to be a complete sentence. Could you remove the line separator?”
There was a problem hiding this comment.
Yeah, it is a good point.
I removed it.
Thank you for your comment.
clarkwtc
force-pushed
the
minor-fix-newline-not-working-in-listeners-doc
branch
from
1431d45 to
5e9f528
Compare
chia7712
approved these changes
Jan 6, 2025
chia7712
pushed a commit
that referenced
this pull request
Jan 6, 2025
Reviewers: Ken Huang <[email protected]>, PoAn Yang <[email protected]>, Chia-Ping Tsai <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
Reviewers: Ken Huang <[email protected]>, PoAn Yang <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix newlines not working with
%nin LISTENERS_DOCFollowing the Kafka site preview below:
Before
After
Committer Checklist (excluded from commit message)