KAFKA-18142 switch Kafka's Gradle build shadow plugin to com.gradleup.shadow (and upgrade plugin version)
#18018
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p.shadow` (and upgrade plugin version) details: * `io.github.goooler.shadow` plugin was deprecated in favor of `com.gradleup.shadow`: https://github.com/Goooler/shadow?tab=readme-ov-file#gradle-shadow * release notes for version upgrade (8.1.3 -->> 8.3.5): https://gradleup.com/shadow/changes/#v8-3-5-2024-11-03
|
@chia7712 feel free to review. Note: Github Actions bot classified this change as small and it's kind of true (if we only count LOC) and hence CI checks are not triggered, I assume. |
|
Update: I just double-checked one of the PR's mentioned above and there is a chance that issue (incorrect classifier for the published archive) still occurs:
Will convert this to PR a draft and have a second look. |
|
Update 2: there is a JIRA ticket (and corresponding PR) that already covers this subject: https://issues.apache.org/jira/browse/KAFKA-17053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prologue (related PR's):
Action points:
io.github.goooler.shadowtocom.gradleup.shadowRationale: both previous one and currently used shadow plugins are now deprecated (in favor of
com.gradleup.shadow):com.github.johnrengelman.shadowmaintenance was transferred tocom.gradleup.shadow: https://github.com/GradleUp/shadow/tree/8.3.5?tab=readme-ov-file#gradle-shadowio.github.goooler.shadow: changes are ported tocom.gradleup.shadow: https://github.com/Goooler/shadow?tab=readme-ov-file#gradle-shadowPitfall (to keep in mind):
Committer Checklist (excluded from commit message)