Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18083: ClusterInstance custom controllerListener not work #17932

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-18083: ClusterInstance custom controllerListener not work #17932

wants to merge 1 commit into from
+14 −5

Conversation

brandboat
Copy link
Member

@brandboat brandboat commented Nov 24, 2024 •
edited
Loading

related to KAFKA-18083,

this is something missed in https://issues.apache.org/jira/browse/KAFKA-17721, plenty of places are still using hardcoded "CONTROLLER" controller listener name and cause controllerListener property not work.
e.g.

  1. https://github.com/apache/kafka/blob/trunk/test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java#L172
  2. https://github.com/apache/kafka/blob/trunk/test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java#L392
  3. https://github.com/apache/kafka/blob/trunk/test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java#L403

and we should add corresponding test case in ClusterTestExtensionsTest.java

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added tests Test fixes (including flaky tests) small Small PRs labels Nov 24, 2024
@brandboat
Copy link
Member Author

brandboat commented Nov 24, 2024 •
edited
Loading

AC, gentle ping @chia7712 , would you mind take a look ? Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brandboat