KAFKA-18079: consumer-config does not work with console-share-consumer #17925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
approved these changes
Nov 23, 2024
|
The failed case is not related to this PR. It'll be fixed in #17924. |
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18079
branch
from
bd62cd5 to
c908111
Compare
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…apache#17925) Reviewers: Andrew Schofield <[email protected]>, Chia-Ping Tsai <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…apache#17925) Reviewers: Andrew Schofield <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
new Properties(consumerPropsFromFile)[0] does not honor theconsumerPropsFromFilewhen it is viewed as a hash map. TheKafkaShareConsumer[1] converts the properties to a map so the configured values are totally ignored.[0]
kafka/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleShareConsumerOptions.java
Line 185 in 337e2e1
[1]
kafka/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaShareConsumer.java
Line 386 in 337e2e1
Committer Checklist (excluded from commit message)