KAFKA-17956: Remove Admin.listShareGroups #17912
Open
+20
−439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Nov 23, 2024
| @@ -3855,48 +3855,6 @@ public DeleteConsumerGroupOffsetsResult deleteConsumerGroupOffsets( | |||
| return new DeleteConsumerGroupOffsetsResult(future.get(CoordinatorKey.byGroupId(groupId)), partitions); | |||
| } | |||
|
|
|||
| private static final class ListShareGroupsResults { | |||
| private final List<Throwable> errors; | |||
| private final HashMap<String, ShareGroupListing> listings; | |||
There was a problem hiding this comment.
Could you please remove ShareGroupListing as well?
| * The API of this class is evolving, see {@link Admin} for details. | ||
| */ | ||
| @InterfaceStability.Evolving | ||
| public class ListShareGroupsResult { |
There was a problem hiding this comment.
Could you please remove those classes from KIP-932
There was a problem hiding this comment.
Done. I have aligned KIP-932 with KIP-1043. This means:
- Removal of
Admin.listShareGroupsand the associated classes. - Replacement of
ShareGroupStatewith the genericGroupState.
|
Test failure known and fixed by https://issues.apache.org/jira/browse/KAFKA-18078. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIP-1043 introduced
Admin.listGroupsas the way to list all types of groups. As a result,Admin.listShareGroupshas been removed. This PR is the final step of the removal.Committer Checklist (excluded from commit message)