MINOR: convert ProduceRequestTest to KRaft #17780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
jolshan
reviewed
Nov 13, 2024
| }).toMap | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "quorum=kraft") |
There was a problem hiding this comment.
This is just to indicate in the name the test is running via kraft? Just double checking since the quorum is not a parameter in the method.
There was a problem hiding this comment.
the test name is what TestInfo.scala looks at to determine if the test is kraft. Changing the test name was just an easy way of getting it to be kraft
There was a problem hiding this comment.
Ok -- just wasn't sure if we also needed the quorum param.
There was a problem hiding this comment.
in this case, no, since we changed the test name directly. sorry I guess that was a bit obscure :)
soon, we will have everything as kraft and we can get rid of this.
jolshan
approved these changes
Nov 13, 2024
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Nov 15, 2024
Reviewers: Justine Olshan <[email protected]>
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
Reviewers: Justine Olshan <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
Reviewers: Justine Olshan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.