KAFKA-17985: Set share.auto.offset.reset to earliest in ShareRoundTripWorker #17758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tools
build
ShivsundarR
changed the title
AndrewJSchofield
requested changes
Nov 12, 2024
| import java.util.Properties; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import static org.apache.kafka.trogdor.common.WorkerUtils.addConfigsToProperties; |
There was a problem hiding this comment.
Personally, I'd prefer to see WorkerUtils.addConfigsToProperties and WorkerUtils.createAdminClient in the code, rather than using these static imports.
AndrewJSchofield
approved these changes
Nov 12, 2024
omkreddy
approved these changes
Nov 12, 2024
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
…pWorker (apache#17758) After the share.auto.offset.reset dynamic config was added for share groups in this commit - 9db5ed0, we needed to update this config value to "earliest" in ShareRoundTripWorker when it creates the consumer. Reviewers: Andrew Schofield <[email protected]>, Manikumar Reddy <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…pWorker (apache#17758) After the share.auto.offset.reset dynamic config was added for share groups in this commit - 9db5ed0, we needed to update this config value to "earliest" in ShareRoundTripWorker when it creates the consumer. Reviewers: Andrew Schofield <[email protected]>, Manikumar Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
After the
share.auto.offset.resetdynamic config was added for share groups in this commit - 9db5ed0, we needed to update this config value to "earliest" in ShareRoundTripWorker when it creates the consumer.