MINOR Fix JDK versions in CI #17621
Merged
MINOR Fix JDK versions in CI #17621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
approved these changes
Oct 28, 2024
| @@ -178,7 +176,7 @@ jobs: | |||
| THREAD_DUMP_URL: ${{ steps.thread-dump-upload-artifact.outputs.artifact-url }} | |||
| GRADLE_EXIT_CODE: ${{ steps.junit-test.outputs.exitcode }} | |||
| - name: Archive Test Catalog | |||
| if: ${{ always() && matrix.java == '21' }} | |||
There was a problem hiding this comment.
oh, I overlook this ... thanks for fix
abhishekgiri23
pushed a commit
to abhishekgiri23/kafka
that referenced
this pull request
Nov 2, 2024
Our "validate" job was running on JDK 21 while the "test" job was running 11 and 23. This patch updates the validate job to 23 and fixes the test catalog step to only run on JDK 23 (instead of 21) Reviewers: Chia-Ping Tsai <[email protected]>
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
Our "validate" job was running on JDK 21 while the "test" job was running 11 and 23. This patch updates the validate job to 23 and fixes the test catalog step to only run on JDK 23 (instead of 21) Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our "validate" job was running on JDK 21 while the "test" job was running 11 and 23. This patch updates the validate job to 23 and fixes the test catalog step to only run on JDK 23 (instead of 21)