Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17738: upgrade base image from jdk8 to jdk11 #17432

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Yunyung
Copy link
Contributor

@Yunyung Yunyung commented Oct 9, 2024

We are planning to drop JDK 8. This is part of the upgrade from JDK 8 to JDK 11. You can see the full plan here: KAFKA-12894


I randomly picked some E2E tests that do not depend on versions prior to Kafka v1.0.0. See the log below:

TC_PATHS="tests/kafkatest/tests/tools" bash tests/docker/run_tests.sh

WARNING: Ignoring custom format, because both --format and --quiet are set.
Mode provided for system tests run: jvm
docker build --memory=3200m --build-arg ducker_creator= --build-arg jdk_version=openjdk:11 --build-arg UID=1000 --build-arg KAFKA_MODE=jvm -t ducker-ak-openjdk-11 -f /home/yungh/kafka/kafka_fork/kafka_openjdk11/kafka/tests/docker/Dockerfile -- .
[+] Building 1.8s (70/70) FINISHED                                                                                                                                 docker:default
 => [internal] load build definition from Dockerfile                                                                                                                         0.1s
 => => transferring dockerfile: 11.81kB                                                                                                                                      0.0s
 => WARN: MaintainerDeprecated: Maintainer instruction is deprecated in favor of using label (line 47)                                                                       0.1s
 => [internal] load metadata for docker.io/library/openjdk:11
 ------------------------------------snip ------------------------------------
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.4
session_id:       2024-10-09--002
run time:         6 minutes 13.349 seconds
tests run:        15
passed:           15
flaky:            0
failed:           0
ignored:          0
================================================================================
test_id:    kafkatest.tests.tools.replica_verification_test.ReplicaVerificationToolTest.test_replica_lags.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   24.371 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.replica_verification_test.ReplicaVerificationToolTest.test_replica_lags.metadata_quorum=ZK
status:     PASS
run time:   35.922 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=SASL_PLAINTEXT.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   24.232 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=SASL_PLAINTEXT.metadata_quorum=ZK
status:     PASS
run time:   22.637 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=SASL_SSL.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   29.524 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=SASL_SSL.metadata_quorum=ZK
status:     PASS
run time:   27.057 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.kibosh_test.KiboshTest.test_kibosh_service
status:     PASS
run time:   4.563 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=PLAINTEXT.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   18.096 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=PLAINTEXT.metadata_quorum=ZK
status:     PASS
run time:   16.563 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=SSL.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   23.625 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log4j_appender_test.Log4jAppenderTest.test_log4j_appender.security_protocol=SSL.metadata_quorum=ZK
status:     PASS
run time:   21.399 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   55.190 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.log_compaction_test.LogCompactionTest.test_log_compaction.metadata_quorum=ZK
status:     PASS
run time:   53.975 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.trogdor_test.TrogdorTest.test_network_partition_fault
status:     PASS
run time:   7.968 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.tools.trogdor_test.TrogdorTest.test_trogdor_service
status:     PASS
run time:   7.878 seconds
--------------------------------------------------------------------------------

TC_PATHS="tests/kafkatest/tests/client/pluggable_test.py" bash tests/docker/run_tests.sh

================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.4
session_id:       2024-10-09--004
run time:         27.560 seconds
tests run:        2
passed:           2
flaky:            0
failed:           0
ignored:          0
================================================================================
test_id:    kafkatest.tests.client.pluggable_test.PluggableConsumerTest.test_start_stop.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   14.338 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.pluggable_test.PluggableConsumerTest.test_start_stop.metadata_quorum=ZK
status:     PASS
run time:   13.179 seconds
--------------------------------------------------------------------------------

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added tests Test fixes (including flaky tests) small Small PRs labels Oct 9, 2024
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Yunyung, Thanks for your PR, left a comment, PTAL

tests/docker/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit c36b993 into apache:trunk Oct 10, 2024
1 check passed
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants