KAFKA-16896 upgrade spotless version after we drop JDK8 #17423
Conversation
build.gradle
Outdated
| @@ -2832,7 +2824,7 @@ project(':streams:streams-scala') { | |||
| dependsOn 'copyDependantLibs' | |||
| } | |||
|
|
|||
| // spotless 6.14 requires Java 11 at runtime | |||
| // spotless 6.25 requires Java 11 at runtime | |||
| if (JavaVersion.current().isJava11Compatible()) { | |||
There was a problem hiding this comment.
Can we also OR Java 17 in this if condition?
There was a problem hiding this comment.
this check is unnecessary since we assume the JDK 8 is dropped
| // the task `removeUnusedImports` is implemented by google-java-format, | ||
| // and unfortunately the google-java-format version used by spotless 6.14.0 can't work with JDK 21. | ||
| // Hence, we apply spotless tasks only if the env is either JDK11 or JDK17 | ||
| if ((JavaVersion.current().isJava11() || (JavaVersion.current() == JavaVersion.VERSION_17))) { | ||
| apply plugin: 'com.diffplug.spotless' | ||
| spotless { | ||
| java { | ||
| targetExclude('**/generated/**/*.java','**/generated-test/**/*.java') | ||
| importOrder('kafka', 'org.apache.kafka', 'com', 'net', 'org', 'java', 'javax', '', '\\#') | ||
| removeUnusedImports() | ||
| } | ||
| apply plugin: 'com.diffplug.spotless' | ||
| spotless { | ||
| java { | ||
| targetExclude('**/generated/**/*.java','**/generated-test/**/*.java') | ||
| importOrder('kafka', 'org.apache.kafka', 'com', 'net', 'org', 'java', 'javax', '', '\\#') | ||
| removeUnusedImports() |
There was a problem hiding this comment.
I think the limitation written in comment is still their. Can we use removeUnusedImports in JDK 21 already?
There was a problem hiding this comment.
I think the limitation written in comment is still their. Can we use removeUnusedImports in JDK 21 already?
yes, I have tested it on my local. works well
|
@chia7712, @mingyen066 Thanks for your comments, I have been addressed by comments |
|
@m1a2st @chia7712 Have we already dropped JDK8? I still see |
|
@cadonna @cadonna, thanks for your response. We are planning to drop JDK 8, but we need this PR first since we need CI builds under JDK 21. However, spotless can’t run with JDK 21, which means our CI has been running without a spotless check for some time, making build errors more likely. I’ve created tasks for the JDK 8 removal. @frankvicky is working on build.gradle and code cleanup, @Yunyung will update the E2E JDK and clean up old and unsupported Kafka versions, and @m1a2st is going to update the documentation for JDK 8. You can find more details in KAFKA-12894. In short, we’re getting ready to say goodbye to JDK 8 😃. |
Reviewers: Chia-Ping Tsai <[email protected]>
Jira: https://issues.apache.org/jira/browse/KAFKA-16896
update spotless version to 6.25.0 because we drop jdk8 in CI
Committer Checklist (excluded from commit message)