-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR Consolidate junit-platform.properties #17399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If I recall correctly, junit-platform.properties is used to generate the correct test naming, such as quorum=kraft and quorum=zk, for the older test infrastructure. In short, junit-platform.properties can be removed once ZK is completely removed from the tests.
Same four tests are failing on both Java version:
🤔 Edit: Looks like some clients tests make assumptions about the classpath. I'll revert the changes to |
This file also lets us register JUnit plugins easily. This may be coming soon in a future PR :) |
I just open a jira to remove the file 😄 Let me close it |
Now that we have ":test-common" we can fix the underlying problem from KAFKA-17121. We should only have a single junit-platform.properties in our runtime classpath since JUnit does not guarantee which one will be loaded (junit-team/junit5#2794).