MINOR: Remove hamcrest from connect:runtime, raft and server-common #17394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumrah
approved these changes
Oct 7, 2024
Comment on lines
65
to
60
| assertFalse(set.removeAll(Arrays.asList("d"))); | ||
| assertTrue(set.retainAll(asList("a", "b", "c"))); |
There was a problem hiding this comment.
Are these Arrays.asList -> asList changes needed? I think in most places we import Arrays rather than the static method import
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…pache#17394) Reviewers: David Arthur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these modules we only used hamcrest for assertions that can easily be done with plain junit. Also removed hamcrest from metadata as it was not used in that module.
Hamcrest is still used in storage and streams.
Committer Checklist (excluded from commit message)