KAFKA-17636 Fix scram bootstrap records #17305
Merged
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccabe
reviewed
Sep 27, 2024
| @@ -139,6 +139,8 @@ object StorageTool extends Logging { | |||
| if (namespace.getBoolean("standalone")) { | |||
| formatter.setInitialVoters(createStandaloneDynamicVoters(config)) | |||
| } | |||
| Option(namespace.getList("add_scram")). | |||
There was a problem hiding this comment.
I had to double-check this since the no-scram case is actually a null rather than an empty list... 🫤
fvaleri
approved these changes
Sep 27, 2024
mumrah
added a commit
that referenced
this pull request
Sep 28, 2024
Fixes a regression introduced by #16669 which inadvertently stopped processing SCRAM arguments from kafka-storage.sh Reviewers: Colin P. McCabe <[email protected]>, Federico Valeri <[email protected]>
|
back ported to 3.9 as 2cbc5bd |
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Sep 30, 2024
Fixes a regression introduced by apache#16669 which inadvertently stopped processing SCRAM arguments from kafka-storage.sh Reviewers: Colin P. McCabe <[email protected]>, Federico Valeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #16669 which inadvertently stopped processing SCRAM arguments.