Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15073 Close stale PRs [2/n] #17166

Merged
merged 5 commits into from
Sep 11, 2024
Merged

KAFKA-15073 Close stale PRs [2/n] #17166

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4810496
enable closing of stale PRs
mumrah Sep 11, 2024
8d712b2
add closed message
mumrah Sep 11, 2024
60231e5
typo
mumrah Sep 11, 2024
922ddbc
PR feedback
mumrah Sep 11, 2024
a7ef15b
fix days-before-close
mumrah Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,22 @@ jobs:
with:
debug-only: ${{ inputs.dryRun || false }}
operations-per-run: ${{ inputs.operationsPerRun || 100 }}
ascending: true
days-before-stale: 90
days-before-close: -1
days-before-close: 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's probably not doable, but it would be great to close only the PRs where the contributor dropped the ball, and leave the ones waiting for us maintainers to review open.
With the closing message we leave the door open for the contributor to reopen, maybe we can be more explicit stating that it's totally fine to reopen if the PR is under this case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the actions/stale docs

It means that any updates made, or any comments added to the issues or to the pull requests will restart the counter of days before marking as stale.

So, if the contributor adds a comment, it will reset the counter for being stale. I'll clarify this in the stale message.

There is probably some additional automation we can look into for raising our attention to do reviews.

stale-pr-label: 'stale'
stale-pr-message: >
stale-pr-message: |
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please ask a committer for review. If the PR has
merge conflicts, please update it with the latest from trunk (or appropriate release branch)
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.

mumrah marked this conversation as resolved.
Show resolved Hide resolved
close-pr-label: 'closed-stale'
close-pr-message: |
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
Loading