KAFKA-16957: Enable KafkaConsumerTest#configurableObjectsShouldSeeGeneratedClientId to work with CLASSIC and CONSUMER #16370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Jun 17, 2024
| @@ -3197,6 +3197,7 @@ private void prepareJoinGroupAndVerifyReason( | |||
| @ParameterizedTest | |||
| @EnumSource(value = GroupProtocol.class, names = "CLASSIC") | |||
There was a problem hiding this comment.
Please remove names to run CONSUMER protocol
|
@chiacyu could you please rebase code? |
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jul 4, 2024
…ratedClientId to work with CLASSIC and CONSUMER (apache#16370) Reviewers: Kirk True <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on KAFKA-16957, we would want to clean the
CLIENT_IDSbefore the test starts.Committer Checklist (excluded from commit message)