MINOR: Rename uniform assignor's internal builders #16233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreddy-22
reviewed
Jun 6, 2024
...p-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java
Show resolved
Hide resolved
rreddy-22
reviewed
Jun 6, 2024
...p-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java
Outdated
Show resolved
Hide resolved
rreddy-22
reviewed
Jun 6, 2024
...p-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java
Outdated
Show resolved
Hide resolved
rreddy-22
reviewed
Jun 6, 2024
.../main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java
Outdated
Show resolved
Hide resolved
|
Thanks, @rreddy-22. I addressed your comments. |
chia7712
reviewed
Jun 7, 2024
...ain/java/org/apache/kafka/coordinator/group/assignor/UniformHomogenousAssignmentBuilder.java
Outdated
Show resolved
Hide resolved
|
I have re-trigger QA |
dajac
added a commit
that referenced
this pull request
Jun 10, 2024
This patch renames the uniform assignor's builders to match the `SubscriptionType` which is used to determine which one is called. It removes the abstract class `AbstractUniformAssignmentBuilder` which is not necessary anymore. It also applies minor refactoring. Reviewers: Ritika Reddy <[email protected]>, Chia-Ping Tsai <[email protected]>
|
Merged to trunk and to 3.8. |
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
This patch renames the uniform assignor's builders to match the `SubscriptionType` which is used to determine which one is called. It removes the abstract class `AbstractUniformAssignmentBuilder` which is not necessary anymore. It also applies minor refactoring. Reviewers: Ritika Reddy <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames the uniform assignor's builders to match the
SubscriptionTypewhich is used to determine which one is called. It removes the abstract classAbstractUniformAssignmentBuilderwhich is not necessary anymore. It also applies minor refactoring.Committer Checklist (excluded from commit message)