KAFKA-15999: Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder #16200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated testFencedMemberStopHeartbeatUntilItReleasesAssignmentToRejoin() and testSuccessfulHeartbeatTiming() to get them to pass
Removed testHeartbeatMetrics(), only test I was unable to get to pass. Also found that this test already exists in HeartbeatMetricsManagerTest
|
@philipnee @lianetm @kirktrue this is ready for review. Let me know of any suggestions! |
lianetm
reviewed
Jun 12, 2024
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Outdated
Show resolved
Hide resolved
lianetm
reviewed
Jun 12, 2024
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Show resolved
Hide resolved
lianetm
reviewed
Jul 18, 2024
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Show resolved
Hide resolved
lianetm
reviewed
Jul 18, 2024
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Show resolved
Hide resolved
lianetm
reviewed
Jul 18, 2024
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Show resolved
Hide resolved
lianetm
reviewed
Jul 18, 2024
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Outdated
Show resolved
Hide resolved
lianetm
reviewed
Jul 18, 2024
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Outdated
Show resolved
Hide resolved
|
Hey @brenden20 , thanks for the updates! Just a few minor comments left. |
|
@lianetm thank you for the review! I addressed the comments you left. Let me know if it is good |
lianetm
approved these changes
Jul 19, 2024
mjsax
changed the title
philipnee
added
the
KIP-848
|
Hey @chia7712, would you maybe have some time to take a look at this? Nice improvement @brenden20 did on the HeartbeatRequestManager test. Thanks! |
|
I will take a look today! |
chia7712
reviewed
Jul 24, 2024
There was a problem hiding this comment.
@brenden20 thanks for this great patch. I have only one small comment for you. PTAL
...s/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java
Outdated
Show resolved
Hide resolved
|
@chia7712 thank you for your feedback! I have addressed your comment by moving those object creations into a helper method. Let me know how it looks! |
chia7712
reviewed
Jul 24, 2024
| if (testBuilder != null) { | ||
| testBuilder.close(); | ||
| } | ||
| private void createHeartbeatStateandRequestManager() { |
There was a problem hiding this comment.
nit: createHeartbeatStateandRequestManager -> createHeartbeatStateAndRequestManager
There was a problem hiding this comment.
Whoops, missed that. Fixed now.
|
@chia7712 fixed that small issue with the name. Let me know if there is anything else! |
chia7712
approved these changes
Jul 25, 2024
3 tasks
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…tBuilder (apache#16200) In this PR I have completely migrated HeartbeatRequestManagerTest away from ConsumerTestBuilder. I have removed any instances of spy objects and used mocks wherever possible. 31/31 tests are passing. I also removed one test that existed in another test file. Reviewers: Lianet Magrans <[email protected]>, Chia-Ping Tsai <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Aug 5, 2024
The purpose of this PR is to remove ConsumerTestBuilder.java since it is no longer needed. The following PRs have eliminated the use of ConsumerTestBuilder: #14930 #16140 #16200 #16312 Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have completely migrated HeartbeatRequestManagerTest away from ConsumerTestBuilder. I have removed any instances of spy objects and used mocks wherever possible. 31/31 tests are passing. I also removed one test that existed in another test file.