-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-10787: Update spotless version and remove support JDK8 #16176
Changes from 1 commit
1edc40e
ce9cbec
911fa3f
fa9f002
9453039
efe7050
ca30c32
a39d07b
854aa32
95d58e4
abc921e
a015ce6
5524a5e
4c95e24
b5de922
16249c1
75ede30
0f108eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,9 +47,10 @@ plugins { | |
// Updating the shadow plugin version to 8.1.1 causes issue with signing and publishing the shadowed | ||
// artifacts - see https://github.com/johnrengelman/shadow/issues/901 | ||
id 'com.github.johnrengelman.shadow' version '8.1.0' apply false | ||
// the minimum required JRE of 6.14.0+ is 11 | ||
chia7712 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// the spotless before 6.14.0 support JDK8, after 6.23.3 support JDK21 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
WDYT? |
||
// refer:https://github.com/diffplug/spotless/tree/main/plugin-gradle#requirements | ||
id 'com.diffplug.spotless' version "6.13.0" apply false | ||
// https://github.com/diffplug/spotless/pull/1920 | ||
id 'com.diffplug.spotless' version "6.25.0" apply false | ||
} | ||
|
||
ext { | ||
|
@@ -799,7 +800,7 @@ subprojects { | |
skipConfigurations = [ "zinc" ] | ||
} | ||
|
||
if (project.name in spotlessApplyModules) { | ||
if (JavaVersion.current().isJava11Compatible() && (project.name in spotlessApplyModules)) { | ||
apply plugin: 'com.diffplug.spotless' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. another idea: Could we revers the
and then we remove module one by one if we apply the spotless rule. It is more clear then before, since we can "see" which module is not applied. WDYT? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, good idea. |
||
spotless { | ||
java { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need this one. There are
Checkstyle
andSpotless
sections.