Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14509: [4/4] Handle includeAuthorizedOperations #16158

Merged
merged 7 commits into from
Jun 10, 2024
+50 −10
Merged

KAFKA-14509: [4/4] Handle includeAuthorizedOperations #16158

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a11b977
KAFKA-14509: Handle includeAuthorizedOperations
riedelmax May 31, 2024
2228d2a
KAFKA-14509: Extend unit tests to cover authorizedOperations
riedelmax Jun 2, 2024
26b1343
KAFKA-14509: Parameterize Unit Test
riedelmax Jun 7, 2024
1d9bf29
KAFKA-14509: extend integration test with includeAuthorizedOperations…
riedelmax Jun 7, 2024
e64ccc1
Merge remote-tracking branch 'upstream/trunk' into kafka-14509-handle…
riedelmax Jun 7, 2024
df98af1
KAFKA-14509: replace magic number
riedelmax Jun 7, 2024
ba081e1
Merge remote-tracking branch 'upstream/trunk' into riedelmax-kafka-14…
dajac Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7082,11 +7082,12 @@ class KafkaApisTest extends Logging {
assertEquals(Errors.GROUP_AUTHORIZATION_FAILED.code, response.data.errorCode)
}

@Test
def testConsumerGroupDescribe(): Unit = {
@ParameterizedTest
@ValueSource(booleans = Array(true, false))
def testConsumerGroupDescribe(includeAuthorizedOperations: Boolean): Unit = {
val groupIds = List("group-id-0", "group-id-1", "group-id-2").asJava
val consumerGroupDescribeRequestData = new ConsumerGroupDescribeRequestData()
.setIncludeAuthorizedOperations(true)
.setIncludeAuthorizedOperations(includeAuthorizedOperations)
consumerGroupDescribeRequestData.groupIds.addAll(groupIds)
val requestChannelRequest = buildRequest(new ConsumerGroupDescribeRequest.Builder(consumerGroupDescribeRequestData, true).build())

Expand All @@ -7107,11 +7108,12 @@ class KafkaApisTest extends Logging {
).asJava)

// Can't reuse the above list here because we would not test the implementation in KafkaApis then
val authorizedOperationsInt = if (includeAuthorizedOperations) 328 else Int.MinValue;
val describedGroups = List(
new DescribedGroup().setGroupId(groupIds.get(0)),
new DescribedGroup().setGroupId(groupIds.get(1)),
new DescribedGroup().setGroupId(groupIds.get(2))
).map(group => group.setAuthorizedOperations(328)) // Integer representation of authorized operations for this request
).map(group => group.setAuthorizedOperations(authorizedOperationsInt)) // Integer representation of authorized operations for this request
riedelmax marked this conversation as resolved.
Show resolved Hide resolved
val expectedConsumerGroupDescribeResponseData = new ConsumerGroupDescribeResponseData()
.setGroups(describedGroups.asJava)

Expand Down