Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Refactor Values class to fix checkstyle, add benchmark, optimize exceptions #15469

Merged
merged 10 commits into from
May 23, 2024
Merged

MINOR: Refactor Values class to fix checkstyle, add benchmark, optimize exceptions #15469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7a61cf6
MINOR: Add JMH ValuesBenchmark
gharris1727 Feb 16, 2024
1dd7555
MINOR: Add more ValuesTest cases to improve coverage
gharris1727 May 7, 2024
fb516c1
MINOR: Resolve checkstyle warnings in Connect Values class
gharris1727 May 7, 2024
2fa632f
MINOR: Change parseAsExactDecimal to avoid ArithmeticExceptions
gharris1727 Feb 16, 2024
1fdb006
MINOR: Change parseAsTemporal to avoid ParseExceptions
gharris1727 Feb 16, 2024
adc7970
MINOR: Refactor convertTo* implementations to not call generic form
gharris1727 Feb 20, 2024
bd03461
MINOR: call parseAsTemporal directly instead of generic parse
gharris1727 May 7, 2024
80dbeb7
MINOR: rename Parser to Tokenizer, move methods accepting Parser to P…
gharris1727 May 7, 2024
2840239
fixup: revert to old class names
gharris1727 May 13, 2024
8fb6c6e
Merge remote-tracking branch 'upstream/trunk' into minor-refactor-val…
gharris1727 May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions checkstyle/suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
files="(AbstractRequest|AbstractResponse|KerberosLogin|WorkerSinkTaskTest|TransactionManagerTest|SenderTest|KafkaAdminClient|ConsumerCoordinatorTest|KafkaAdminClientTest|KafkaRaftClientTest).java"/>

<suppress checks="NPathComplexity"
files="(ConsumerCoordinator|BufferPool|MetricName|Node|ConfigDef|RecordBatch|SslFactory|SslTransportLayer|MetadataResponse|KerberosLogin|Selector|Sender|Serdes|TokenInformation|Agent|Values|PluginUtils|MiniTrogdorCluster|TasksRequest|KafkaProducer|AbstractStickyAssignor|KafkaRaftClient|Authorizer|FetchSessionHandler|RecordAccumulator|Shell).java"/>
files="(ConsumerCoordinator|BufferPool|MetricName|Node|ConfigDef|RecordBatch|SslFactory|SslTransportLayer|MetadataResponse|KerberosLogin|Selector|Sender|Serdes|TokenInformation|Agent|PluginUtils|MiniTrogdorCluster|TasksRequest|KafkaProducer|AbstractStickyAssignor|KafkaRaftClient|Authorizer|FetchSessionHandler|RecordAccumulator|Shell).java"/>

<suppress checks="(JavaNCSS|CyclomaticComplexity|MethodLength)"
files="CoordinatorClient.java"/>
Expand Down Expand Up @@ -143,7 +143,7 @@
<suppress checks="ClassFanOutComplexity"
files="Worker(|Test).java"/>
<suppress checks="MethodLength"
files="(DistributedHerder|DistributedConfig|KafkaConfigBackingStore|Values|IncrementalCooperativeAssignor).java"/>
files="(DistributedHerder|DistributedConfig|KafkaConfigBackingStore|IncrementalCooperativeAssignor).java"/>
<suppress checks="ParameterNumber"
files="Worker(SinkTask|SourceTask|Coordinator)?.java"/>
<suppress checks="ParameterNumber"
Expand All @@ -160,10 +160,10 @@
<suppress checks="CyclomaticComplexity"
files="(FileStreamSourceTask|DistributedHerder|KafkaConfigBackingStore).java"/>
<suppress checks="CyclomaticComplexity"
files="(JsonConverter|Values|ConnectHeaders).java"/>
files="(JsonConverter|ConnectHeaders).java"/>

<suppress checks="JavaNCSS"
files="(KafkaConfigBackingStore|Values|ConnectMetricsRegistry).java"/>
files="(KafkaConfigBackingStore|ConnectMetricsRegistry).java"/>

<suppress checks="NPathComplexity"
files="(DistributedHerder|AbstractHerder|RestClient|RestServer|JsonConverter|KafkaConfigBackingStore|FileStreamSourceTask|WorkerSourceTask|TopicAdmin).java"/>
Expand Down
Loading