Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Delete unused classes #14797

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

ijuma
Copy link
Member

@ijuma ijuma commented Nov 19, 2023

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

try {
server1.startup()
} catch {
case _: kafka.common.InconsistentBrokerIdException => //success
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked question here #14628 (comment)

Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ijuma ijuma force-pushed the delete-unused-classes branch from 755cba1 to c850424 Compare January 20, 2024 23:44
@ijuma ijuma merged commit 70e0dbd into apache:trunk Jan 24, 2024
1 check failed
@ijuma ijuma deleted the delete-unused-classes branch January 24, 2024 06:04
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
Phuc-Hong-Tran pushed a commit to Phuc-Hong-Tran/kafka that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants