[MINOR] QuorumController tests use testToImage #14405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rondagostino
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
LGTM. Could you merge in latest changes from trunk to force a new build? The one for this iteration failed with what looks like some kind of infrastructure issue. I was able to successfully run the tests locally, but best to get a clean build before merging if possible.
|
None of the failed tests are from the affected file |
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Oct 3, 2023
k-wall
pushed a commit
to k-wall/kafka
that referenced
this pull request
Nov 21, 2023
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that records generated from existing QuorumController tests will generate the same final image regardless of how they are batched in replay.
Builds on top of #13724
Committer Checklist (excluded from commit message)