KAFKA-14133: Move MeteredSessionStoreTest, MeteredWindowStoreTest and ReadOnlyKeyValueStoreFacadeTest to Mockito #14404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ReadOnlyKeyValueStoreFacadeTest to Mockito
clolov
commented
Sep 19, 2023
| STORE_TYPE, | ||
| Serdes.String(), | ||
| Serdes.String(), | ||
| new MockTime() | ||
| ); | ||
| expect(inner.name()).andStubReturn("store"); |
There was a problem hiding this comment.
This is unneeded here and elsewhere due to being initialised in the setup method.
clolov
commented
Sep 19, 2023
| store.init((StateStoreContext) context, store); | ||
| } | ||
|
|
||
| @SuppressWarnings("deprecation") | ||
| @Test | ||
| public void shouldDelegateDeprecatedInit() { | ||
| final SessionStore<Bytes, byte[]> inner = mock(SessionStore.class); |
There was a problem hiding this comment.
This is unneeded here and elsewhere due to already being defined as a field.
divijvaidya
approved these changes
Sep 22, 2023
|
The tests failures are unrelated and build is successful - https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14404/1/pipeline |
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Oct 3, 2023
… ReadOnlyKeyValueStoreFacadeTest to Mockito (apache#14404) Reviewers: Divij Vaidya <[email protected]>
k-wall
pushed a commit
to k-wall/kafka
that referenced
this pull request
Nov 21, 2023
… ReadOnlyKeyValueStoreFacadeTest to Mockito (apache#14404) Reviewers: Divij Vaidya <[email protected]>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
… ReadOnlyKeyValueStoreFacadeTest to Mockito (apache#14404) Reviewers: Divij Vaidya <[email protected]>
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Feb 22, 2024
… ReadOnlyKeyValueStoreFacadeTest to Mockito (apache#14404) Reviewers: Divij Vaidya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests migrates mocks from MeteredSessionStoreTest, MeteredWindowStoreTest and ReadOnlyKeyValueStoreFacadeTest to Mockito.