Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fix help message for kafka-metadata-shell. #13867

Merged
merged 1 commit into from
Sep 11, 2023
Merged

MINOR: Fix help message for kafka-metadata-shell. #13867

merged 1 commit into from
Sep 11, 2023

Conversation

tkuramoto33
Copy link
Contributor

The current help message for kafka-metadata-shell.sh is as follows.

$ ~/kafka_2.13-3.5.0/bin/kafka-metadata-shell.sh -h
usage: metadata-tool [-h] [--snapshot SNAPSHOT] [command [command ...]]

The Apache Kafka metadata tool

(omitted.)

However, it should be as follows.

$ ~/kafka_2.13-3.5.0/bin/kafka-metadata-shell.sh -h
usage: kafka-metadata-shell [-h] [--snapshot SNAPSHOT] [command [command ...]]

The Apache Kafka metadata shell

(omitted.)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@tkuramoto33
Copy link
Contributor Author

@cmccabe
I'm sorry to bother you, but could you please review this PR?

dengziming
dengziming approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@dengziming dengziming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dengziming dengziming merged commit 37c01e9 into apache:trunk Sep 11, 2023
@tkuramoto33 tkuramoto33 deleted the fix-help-message-for-kafka-metadata-shell branch September 23, 2023 07:43
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
@tkuramoto33 @AnatolyPopov
MINOR: Fix help message for kafka-metadata-shell (apache#13867)
4074064 
Reviewers: Ziming Deng [email protected]
Cerchie pushed a commit to Cerchie/kafka that referenced this pull request Feb 22, 2024
@tkuramoto33 @Cerchie
MINOR: Fix help message for kafka-metadata-shell (apache#13867)
abb34e4 
Reviewers: Ziming Deng [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengziming dengziming dengziming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkuramoto33 @dengziming