-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Enable spotless for streams-scala when Java 11+ is used #13311
Conversation
Also re-enable it in CI. We do this by adjusting the `Jenkinsfile` to use a more general task (`./gradlew check -x test`).
@@ -2116,6 +2109,17 @@ project(':streams:streams-scala') { | |||
dependsOn 'copyDependantLibs' | |||
} | |||
|
|||
// spotless 6.14 requires Java 11 at runtime | |||
if (JavaVersion.current().isJava11Compatible()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it imply the developers who want to contribute code to streams-scala must use JDK11 as our Ci will check that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, developers don't have to use Java 11. They can rely on CI for the rare case where this module is being updated and they didn't follow the style rules. It is more practical to use Java 11 or newer though. I don't think it's a problem - Java 8 support is more for deployments than for contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice approach, LGTM
CI build looks good, there were unrelated failures. Restarted just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also re-enable it in CI. We do this by adjusting the
Jenkinsfile
to use a more general task (./gradlew check -x test
).Committer Checklist (excluded from commit message)