Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: the package of JmxTool is incorrect when running quota_test.py #13233

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

chia7712
Copy link
Member

related to #13136

JmxTool was moved from kafka.tools.JmxTool to org.apache.kafka.tools.JmxTool.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712 chia7712 requested a review from mimaison February 11, 2023 17:43
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 LGTM.

Thanks for fixing this and sorry if it caused any inconvenience.

I ran every failing ST from this branch on my local machine.

TC_PATHS="tests/kafkatest/tests/core/mirror_maker_test.py::TestMirrorMakerService.test_bounce" \
  _DUCKTAPE_OPTIONS='--parameters '\''{"clean_shutdown":"false","security_protocol":"PLAINTEXT"}'\' \
    bash tests/docker/run_tests.sh

--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.mirror_maker_test.TestMirrorMakerService.test_bounce.clean_shutdown=false.security_protocol=PLAINTEXT
status:     PASS
run time:   2 minutes 41.021 seconds
--------------------------------------------------------------------------------

TC_PATHS="tests/kafkatest/tests/client/quota_test.py::QuotaTest.test_quota" \
    bash tests/docker/run_tests.sh

--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=.user.client-id.override_quota=False
status:     PASS
run time:   4 minutes 55.564 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=.user.client-id.override_quota=True
status:     PASS
run time:   2 minutes 54.707 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.consumer_num=2
status:     PASS
run time:   3 minutes 41.160 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.old_broker_throttling_behavior=True
status:     PASS
run time:   2 minutes 47.152 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.old_client_throttling_behavior=True
status:     PASS
run time:   2 minutes 52.824 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.override_quota=False
status:     PASS
run time:   4 minutes 57.153 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=client-id.override_quota=True
status:     PASS
run time:   2 minutes 54.194 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=user.override_quota=False
status:     PASS
run time:   3 minutes 57.129 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.client.quota_test.QuotaTest.test_quota.quota_type=user.override_quota=True
status:     PASS
run time:   3 minutes 6.432 seconds
--------------------------------------------------------------------------------

Copy link
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 69f0481 into apache:trunk Feb 12, 2023
@chia7712 chia7712 deleted the minor-13233 branch March 25, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants