MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool #11694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachikuji
reviewed
Jan 21, 2022
hachikuji
reviewed
Jan 22, 2022
| * field therefore always reflects the timestamp of the first record in the batch. If the batch is empty, the | ||
| * FirstTimestamp will be set to -1 (NO_TIMESTAMP). | ||
| * BaseTimestamp will be set to -1 (NO_TIMESTAMP). |
There was a problem hiding this comment.
The comment is still inaccurate, no? The base timestamp does not always reflect the timestamp of the first record in the batch.
There was a problem hiding this comment.
you are right, thanks for the catch. I've revised the comments to be accurate about BaseTimestamp after compaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation and tooling to match the changes made in #10914
In the documentation, changes include the adding the new attribute and updating field names.
In the DumpLogSegments tool, when record batch information is printed, it will also include what the value of deleteHorizonMs is (
OptionalLong.emptyorOptionalLong[123456])