Skip to content

Commit

Permalink
MINOR: Do not log retriable offset commit exceptions as errors (#5904)
Browse files Browse the repository at this point in the history
Reviewers: Jason Gustafson <[email protected]>
  • Loading branch information
t3hnar authored and hachikuji committed Apr 25, 2019
1 parent 0589810 commit 725e184
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,11 @@ public void handle(OffsetCommitResponse commitResponse, RequestFuture<Void> futu
if (error == Errors.NONE) {
log.debug("Committed offset {} for partition {}", offset, tp);
} else {
log.error("Offset commit failed on partition {} at offset {}: {}", tp, offset, error.message());
if (error.exception() instanceof RetriableException) {
log.warn("Offset commit failed on partition {} at offset {}: {}", tp, offset, error.message());
} else {
log.error("Offset commit failed on partition {} at offset {}: {}", tp, offset, error.message());
}

if (error == Errors.GROUP_AUTHORIZATION_FAILED) {
future.raise(new GroupAuthorizationException(groupId));
Expand Down

0 comments on commit 725e184

Please sign in to comment.