HOTFIX: testInitTransactionTimeout should use prepareResponse instead…

… of respond (#8179) We have seen a flaky behavior due to using #respond instead of #prepareResponse call for the txn test. Reviewers: Guozhang Wang <[email protected]>
apache · Feb 27, 2020 · 399d18f · 399d18f
1 parent fb5bd9e
commit 399d18f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/clients/src/test/java/org/apache/kafka/clients/MockClient.java b/clients/src/test/java/org/apache/kafka/clients/MockClient.java
@@ -44,12 +44,7 @@
  * A mock network client for use testing code
  */
 public class MockClient implements KafkaClient {
-    public static final RequestMatcher ALWAYS_TRUE = new RequestMatcher() {
-        @Override
-        public boolean matches(AbstractRequest body) {
-            return true;
-        }
-    };
+    public static final RequestMatcher ALWAYS_TRUE = body -> true;
 
     private static class FutureResponse {
         private final Node node;

diff --git a/clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java b/clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
@@ -767,7 +767,11 @@ public void testInitTransactionTimeout() {
 
             assertThrows(TimeoutException.class, producer::initTransactions);
 
-            client.respond(FindCoordinatorResponse.prepareResponse(Errors.NONE, host1));
+            client.prepareResponse(
+                request -> request instanceof FindCoordinatorRequest &&
+                               ((FindCoordinatorRequest) request).data().keyType() == FindCoordinatorRequest.CoordinatorType.TRANSACTION.id(),
+                FindCoordinatorResponse.prepareResponse(Errors.NONE, host1));
+
             client.prepareResponse(initProducerIdResponse(1L, (short) 5, Errors.NONE));
 
             // retry initialization should work