Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAMES-3945 Subaddressing - case sensitivity and subfolders #2435

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

florentos17
Copy link
Contributor

@florentos17 florentos17 commented Oct 3, 2024

  1. Currently we have a case sensitivity problem: folders are case sensitive whereas email addresses are not. We would want both fazavant+folder@domain and fazavant+Folder@domain to be delivered in my folder Folder. Moreover, if both folder and Folder exist, the correct one should be selected.

  2. Since we agreed to give the p right to either noone or anyone, there is no need for unit tests about whitelists and blacklists: I removed them

  3. We want to check whether a subfolder can be subaddressed. I wrote a unit test that sends an email to fazavant+folder/subfoder@domain, and it seems to be all good :) is that enough or should I write more advanced tests ?

Copy link
Contributor

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it nothing to add

@florentos17
Copy link
Contributor Author

i created a new implementation of MailboxNameExpression to find only the mailboxes that match the name without taking the case into account - it is almost identical to the existing ExactName except for the isExpressionMatch and includeChildren methods.
i added unit tests which are also extremely similar to those of ExactName: just a couple of extra tests to test various cases.

@chibenwa chibenwa merged commit 256c89d into apache:master Oct 7, 2024
1 check passed
@florentos17 florentos17 deleted the Subaddressing-Case-Sensitivity branch October 7, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants