-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAMES-3945 Subaddressing - case sensitivity and subfolders #2435
JAMES-3945 Subaddressing - case sensitivity and subfolders #2435
Conversation
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/SubAddressingTest.java
Outdated
Show resolved
Hide resolved
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/SubAddressing.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read it nothing to add
…ameExpression` to load only the wanted items
mailbox/api/src/main/java/org/apache/james/mailbox/model/search/ExactNameCaseIncensitive.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/org/apache/james/mailbox/model/search/PrefixedWildcardCaseIncensitive.java
Outdated
Show resolved
Hide resolved
i created a new implementation of |
Currently we have a case sensitivity problem: folders are case sensitive whereas email addresses are not. We would want both
fazavant+folder@domain
andfazavant+Folder@domain
to be delivered in my folderFolder
. Moreover, if bothfolder
andFolder
exist, the correct one should be selected.Since we agreed to give the
p
right to either noone or anyone, there is no need for unit tests about whitelists and blacklists: I removed themWe want to check whether a subfolder can be subaddressed. I wrote a unit test that sends an email to
fazavant+folder/subfoder@domain
, and it seems to be all good :) is that enough or should I write more advanced tests ?