JAMES-2586 - Fixup InMemoryUploadRepository.deleteByUploadDateBefore

- Fix java.util.ConcurrentModificationException
- Fix test InMemoryUploadRepositoryTest

server/data/data-jmap/src/main/java/org/apache/james/jmap/memory/upload/InMemoryUploadRepository.java

@@ -25,6 +25,7 @@
 import java.time.Duration;
 import java.time.Instant;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
 import jakarta.inject.Inject;
@@ -113,7 +114,7 @@ public Publisher<UploadMetaData> listUploads(Username user) {
     @Override
     public Publisher<Void> deleteByUploadDateBefore(Duration expireDuration) {
         Instant expirationTime = clock.instant().minus(expireDuration);
-        return Flux.fromIterable(uploadStore.values())
+        return Flux.fromIterable(List.copyOf(uploadStore.values()))
             .filter(pair -> pair.right.uploadDate().isBefore(expirationTime))
             .flatMap(pair -> Mono.from(blobStore.delete(bucketName, pair.right.blobId()))
                 .then(Mono.fromRunnable(() -> uploadStore.remove(pair.right.uploadId()))))

server/data/data-jmap/src/test/java/org/apache/james/jmap/memory/upload/InMemoryUploadRepositoryTest.java

@@ -39,8 +39,8 @@ public class InMemoryUploadRepositoryTest implements UploadRepositoryContract {
     @BeforeEach
     void setUp() {
         BlobStore blobStore = new DeDuplicationBlobStore(new MemoryBlobStoreDAO(), BucketName.DEFAULT, new PlainBlobId.Factory());
-        testee = new InMemoryUploadRepository(blobStore, Clock.systemUTC());
         clock = new UpdatableTickingClock(Clock.systemUTC().instant());
+        testee = new InMemoryUploadRepository(blobStore, clock);
     }
 
     @Override