Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11537][Sort] Optimize the session key generation of TubeMQ Source #11538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vernedeng
Copy link
Contributor

Fixes #11537

Motivation

Optimize the session key generation of TubeMQ Source

Modifications

The original way to generate a session key is to combine the job id with the base session key, which leads to data loss in the case of flink failover with only one task restart due to the reuse of the same session key.

The more reasonable way is to find a unique key different from the former one after each failover.

image

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] Optimize the session key generation of TubeMQ Source
2 participants