Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-10566][Manager] Fix auth failed and cronexpression field type error #10567

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[INLONG-10566][Manager] Fix auth failed and cronexpression field type error #10567

merged 1 commit into from
Jul 5, 2024

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Jul 4, 2024 •
edited
Loading

Fixes #10566

Motivation

fix auth failed and cronexpression field type

Modifications

  1. fix auth error
  2. fix cronexpression field type error
  3. correct schedule_unit to default null, since when crontab expression is not null schedule_unit can be null

Verifying this change

  • This change is a trivial rework/code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (no)

@aloyszhang aloyszhang changed the title [INLONG-10566][Manager] fix auth failed and cronexpression field type error [INLONG-10566][Manager] Fix auth failed and cronexpression field type error Jul 4, 2024
@aloyszhang aloyszhang added this to the 1.13.0 milestone Jul 5, 2024
@aloyszhang aloyszhang self-assigned this Jul 5, 2024
baomingyu
baomingyu approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@baomingyu baomingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aloyszhang aloyszhang merged commit 2f67c34 into apache:dev-offline-sync Jul 5, 2024
12 checks passed
@aloyszhang aloyszhang deleted the fix-auth branch July 5, 2024 02:32
aloyszhang added a commit to aloyszhang/inlong that referenced this pull request Jul 9, 2024
@aloyszhang
[INLONG-10566][Manager] fix auth failed and cronexpression field type (…
69671d9 
…apache#10567)

Co-authored-by: Aloys Zhang <[email protected]>
aloyszhang added a commit that referenced this pull request Jul 9, 2024
@aloyszhang
[INLONG-10566][Manager] fix auth failed and cronexpression field type (…
b9f1bcf 
…#10567)

Co-authored-by: Aloys Zhang <[email protected]>
aloyszhang added a commit to aloyszhang/inlong that referenced this pull request Jul 9, 2024
@aloyszhang
[INLONG-10566][Manager] fix auth failed and cronexpression field type (…
b807cb7 
…apache#10567)

Co-authored-by: Aloys Zhang <[email protected]>
aloyszhang added a commit that referenced this pull request Jul 9, 2024
@aloyszhang
[INLONG-10566][Manager] fix auth failed and cronexpression field type (…
2e3d4fb 
…#10567)

Co-authored-by: Aloys Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baomingyu baomingyu baomingyu approved these changes

@fuweng11 fuweng11 fuweng11 approved these changes

@dockerzhang dockerzhang Awaiting requested review from dockerzhang

@vernedeng vernedeng Awaiting requested review from vernedeng

Assignees

@aloyszhang aloyszhang

Labels
component/manager
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aloyszhang @baomingyu @fuweng11