-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-10436][Manager] Move schedule configuration from stream to group #10437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerzhang
changed the title
[INLONG-10436][Manager] move scheudle configuration from stream to group
[INLONG-10436][Manager] Move schedule configuration from stream to group
Jun 17, 2024
fuweng11
approved these changes
Jun 18, 2024
dockerzhang
approved these changes
Jun 18, 2024
35 tasks
aloyszhang
added a commit
that referenced
this pull request
Jun 20, 2024
aloyszhang
added a commit
that referenced
this pull request
Jun 22, 2024
aloyszhang
added a commit
that referenced
this pull request
Jun 25, 2024
aloyszhang
added a commit
to aloyszhang/inlong
that referenced
this pull request
Jul 9, 2024
aloyszhang
added a commit
that referenced
this pull request
Jul 9, 2024
aloyszhang
added a commit
to aloyszhang/inlong
that referenced
this pull request
Jul 9, 2024
aloyszhang
added a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10436
Motivation
#9865 Support submits a Flink job for offline sync, and the schedule status is saved with an inlong stream.
But for the real-time sync job, there is only one stream in a group(one Flink job one stream), to keep consistency, we should keep the schedule information at the group level.
Modifications
manager-schedule
module, fromorg.apache.inlong.schedule
toorg.apache.inlong.manager.schedule
Verifying this change
(Please pick either of the following options)
covered by
org.apache.inlong.manager.service.workflow.group.CreateGroupWorkflowDefinitionTest.java
Documentation