Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10191][Agent] Delete the useless code related to 8008 listen port #10192

Merged
merged 5 commits into from
May 13, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented May 12, 2024

Fixes #10191

Motivation

The agent does not listen to the port, and the relevant code is useless

Modifications

Delete useless code

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@dockerzhang dockerzhang changed the title [INLONG-10091][Agent] Delete useless code [INLONG-10091][Agent] Delete the useless code related to 8008 listen port May 12, 2024
dockerzhang
dockerzhang previously approved these changes May 13, 2024
@EMsnap
Copy link
Contributor

EMsnap commented May 13, 2024

public static final String AGENT_ENABLE_HTTP = "agent.http.enable";
public static final boolean DEFAULT_AGENT_ENABLE_HTTP = false; these codes should also be deleted

@EMsnap
Copy link
Contributor

EMsnap commented May 13, 2024

@dockerzhang
Copy link
Contributor

@justinwwhuang justinwwhuang merged commit 808cf79 into apache:master May 13, 2024
9 checks passed
@justinwwhuang justinwwhuang deleted the b1091 branch May 13, 2024 08:43
@justinwwhuang justinwwhuang changed the title [INLONG-10091][Agent] Delete the useless code related to 8008 listen port [INLONG-10191][Agent] Delete the useless code related to 8008 listen port May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Delete useless code
4 participants