Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-10091][Sort] Add json format for 1.18 #10092

Merged
merged 2 commits into from
May 8, 2024
Merged

[INLONG-10091][Sort] Add json format for 1.18 #10092

merged 2 commits into from
May 8, 2024

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Apr 28, 2024 •
edited
Loading

Fixes #10091

Motivation

Add JSON format for 1.18, and make sure the inlong-sort module can be built with profile v1.18

Modifications

  • add format-json-v1.18 module
  • resolve flink 1.18 format JSON compatible issue
  • make sure the whole project can be build with profile -Pv1.18

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (no)

@aloyszhang aloyszhang self-assigned this Apr 28, 2024
@dockerzhang dockerzhang self-requested a review May 6, 2024 02:38
@EMsnap
Copy link
Contributor

EMsnap commented May 6, 2024

I guess module sort-format-json-v1.18 is not built on our build workflow ?

@aloyszhang
Copy link
Contributor Author

aloyszhang commented May 7, 2024 •
edited
Loading

I guess module sort-format-json-v1.18 is not built on our build workflow ?

It's built only by specifying profile v1.18 mvn clean package -DskipTests -Pv1.18

@EMsnap
Copy link
Contributor

EMsnap commented May 7, 2024

I guess module sort-format-json-v1.18 is not built on our build workflow ?

It's built only by specifying profile v1.18 mvn clean package -DskipTests -Pv1.18

Yes and my point is that the workflow hasn't run -Pv1.18 so the module is not build for testifing
image

@aloyszhang
Copy link
Contributor Author

aloyszhang commented May 7, 2024 •
edited
Loading

I guess module sort-format-json-v1.18 is not built on our build workflow ?

It's built only by specifying profile v1.18 mvn clean package -DskipTests -Pv1.18

Yes and my point is that the workflow hasn't run -Pv1.18 so the module is not build for testifing image

You're right, in the current workflow, this module is not built.
I'll bring another pull request for testifying with -Pv1.18.

@dockerzhang dockerzhang merged commit bf42e1a into apache:master May 8, 2024
10 checks passed
herywang pushed a commit to herywang/inlong that referenced this pull request May 9, 2024
@aloyszhang @herywang
[INLONG-10091][Sort] Add json format for Flink 1.18 (apache#10092)
2496258
@aloyszhang aloyszhang deleted the format-json-1.18 branch June 5, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baomingyu baomingyu baomingyu approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@EMsnap EMsnap EMsnap approved these changes

Assignees

@aloyszhang aloyszhang

Labels
component/sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Add json format for 1.18
4 participants
@aloyszhang @EMsnap @baomingyu @dockerzhang