Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#933] fix: incorrect metric grpc_server_connection_number #934

Merged
merged 1 commit into from
Jun 8, 2023
Merged

[#933] fix: incorrect metric grpc_server_connection_number #934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion common/src/main/java/org/apache/uniffle/common/rpc/MonitoringServerTransportFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ public Attributes transportReady(Attributes transportAttrs) {
}

public void transportTerminated(Attributes transportAttrs) {
grpcMetrics.decGauge(GRPC_SERVER_CONNECTION_NUMBER_KEY);
if (transportAttrs != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you check when the transportAttrs will be null?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in which case, the transportAttrs is null?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When handshake fails.
grpc/grpc-java#7625 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use telnet to trigger the problem. Just close it when telnet connect to rpc port.

grpcMetrics.decGauge(GRPC_SERVER_CONNECTION_NUMBER_KEY);
}
super.transportTerminated(transportAttrs);
}
}