-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#796][0.7] bug: Fix the issues of MetricReporter #821
Conversation
### What changes were proposed in this pull request? Support custom config keys defined in plugins Refactor the logic for load config file Fix some issues of metricReporter. ### Why are the changes needed? Metric reporter is unusable. Fix: apache#796 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? UT and Manual testing # Conflicts: # common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java # server/src/test/java/org/apache/uniffle/server/ShuffleServerConfTest.java
Codecov Report
@@ Coverage Diff @@
## branch-0.7 #821 +/- ##
================================================
- Coverage 60.89% 60.78% -0.12%
+ Complexity 1800 1792 -8
================================================
Files 214 214
Lines 12386 12374 -12
Branches 1042 1045 +3
================================================
- Hits 7543 7521 -22
- Misses 4440 4449 +9
- Partials 403 404 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It seems that this PR is merged to master in CI enviroment. But the first time is ok. |
I cherry-pick a wrong commit. I have reverted it. it's strange that it influence your pr. You could rerun your pr. |
Please rebase or merge branch-0.7. |
It is ok now, just reopen it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xianjingfeng
What changes were proposed in this pull request?
Why are the changes needed?
Metric reporter is unusable.
Fix: #796
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT and Manual testing