[Relay][Frontend][Onnx] Small bug fix for Conv1D imports. #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masahi, @areusch, @tmoreau89 can one of you guys take a look at this quick PR? |
masahi
approved these changes
Jul 6, 2020
|
Thanks @jwfromm @tmoreau89 @junrushao1994 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
* Fix autopad bug in onnx importer for conv1d. * Fix output shape in test. * Undo commented out lines oops.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
* Fix autopad bug in onnx importer for conv1d. * Fix output shape in test. * Undo commented out lines oops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a Conv1D operation with VALID padding, a Relay error would be produced due to the onnx frontend generating a tuple with only one element instead of two as expected. Adding
get_pad_tuple1dto themake_conv1dcall covers this and is more robust than the previous approach.