[PYTORCH]Reduce_ops support added #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siju-samuel please fix the CI error |
siju-samuel
force-pushed
the
pytorch_reduce_ops
branch
from
b1ad4cd to
eff5a90
Compare
|
"Test code" doesn't mean code quality can be low. Add blank lines following established python style convention. Each function or class definition are supposed to have two blank lines between them at the top level, and one line if defined inside a function |
|
@masahi Thanks a lot for the review. Updated. |
masahi
approved these changes
Apr 13, 2020
|
@siju-samuel sorry my PR #5306 was just merged and has conflict with this one. Can you rebase? |
|
@siju-samuel sorry again, I just found a typo bug in our qnn test https://github.com/apache/incubator-tvm/blob/03cbf78e3e8cc910c5a9c95cd3fcafa19959644f/tests/python/frontend/pytorch/qnn_test.py#L399 Can you change |
siju-samuel
force-pushed
the
pytorch_reduce_ops
branch
from
8f4d971 to
86c756e
Compare
|
thanks @masahi, Done. Please have a look |
siju-samuel
force-pushed
the
pytorch_reduce_ops
branch
from
10bee0b to
c03374e
Compare
|
Thanks! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [PYTORCH]Reduce_ops support added * Review comments updated * typo bug in qnn test
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [PYTORCH]Reduce_ops support added * Review comments updated * typo bug in qnn test
dpankratz
pushed a commit
to dpankratz/incubator-tvm
that referenced
this pull request
Apr 24, 2020
* [PYTORCH]Reduce_ops support added * Review comments updated * typo bug in qnn test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@masahi please help to review and merge this PR. Thanks in advance.