-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TFLite] Using real image for QNN testing. #4816
Conversation
c054e3e
to
aafb334
Compare
@inadob Can you please review the TFLite pad test portion? I am not very familiar with using fake quant, and I just replicated your code for Pad. So, closer scrutiny would be good. |
Ping @FrozenGene |
ping @inadob , would you review it again? If you have no other comments, would you set explicit approve? Thanks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready, have a couple of small changes below
f6ada9e
to
799dfaf
Compare
@inadob Done |
799dfaf
to
6529512
Compare
@FrozenGene Good to merge? |
Thanks @anijain2305 @inadob It is merged now. |
What happen if the zero point is a vector, as in per channel quantization? What should the pad value be? |
@masahi good question but please file a separate issue only affecting master since per channel quantization came in after this. Otherwise I fear this will be missed. Ramana |
@anijain2305 - this needs a backport to 0.6 tag ? |
@u99127 I figured the answer myself. QNN support for per channel quantization applies to only weight quantization (which is supposed to be a common restriction in other frameworks as well). For pad value we can use a scalar zero point associated with activations. |
* [TFLite] Using real image for QNN testing. * Setting seed for SSD mobilenet for fixed input. * Support quantized Pad op. * Remove unnnecessary line. * Ina comments.
* [TFLite] Using real image for QNN testing. * Setting seed for SSD mobilenet for fixed input. * Support quantized Pad op. * Remove unnnecessary line. * Ina comments.
* [TFLite] Using real image for QNN testing. * Setting seed for SSD mobilenet for fixed input. * Support quantized Pad op. * Remove unnnecessary line. * Ina comments.
This PR does 2 things
Thanks to @inadob for finding the bug
@FrozenGene @kevinthesun @inadob Can you please review?