Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend][TFlite] Add support for quantized LOGISTIC #4696

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

inadob
Copy link
Contributor

@inadob inadob commented Jan 13, 2020

This patch is built on top of two pending PRs: #4789 and #4805 (only 70dfaf6)

  • add qnn implementation in the parser
  • add test case for qnn logistic

@inadob
Copy link
Contributor Author

inadob commented Jan 13, 2020

@anijain2305 @FrozenGene, can you please check this patch

@u99127
Copy link
Contributor

u99127 commented Jan 20, 2020

* add qnn implementation in the parser

* add test case for qnn logistic

LGTM

Ramana

@u99127
Copy link
Contributor

u99127 commented Jan 29, 2020

ping for an approving review ? @FrozenGene @anijain2305.

@inadob inadob closed this Jan 31, 2020
@inadob inadob reopened this Feb 3, 2020
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for such a late review. LGTM.

@FrozenGene @u99127 I think we are converging on keeping FP32 softmax for now. I think, once Ina addresses the comments, we can get this PR in.

tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
@anijain2305
Copy link
Contributor

@inadob Please rebase

@tqchen tqchen added the status: need update need update based on feedbacks label Feb 6, 2020
@tqchen
Copy link
Member

tqchen commented Feb 6, 2020

@inadob please rebase, @FrozenGene please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

@FrozenGene
Copy link
Member

Thanks @inadob @anijain2305 @u99127 This is merged.

@FrozenGene FrozenGene merged commit 5a13575 into apache:master Feb 7, 2020
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Feb 10, 2020
…4696)

* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC

 * add qnn implementation
 * add qnn test case for qnn logistic

* Helper functions for quantize and dequantize.
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
…4696)

* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC

 * add qnn implementation
 * add qnn test case for qnn logistic

* Helper functions for quantize and dequantize.
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
…4696)

* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC

 * add qnn implementation
 * add qnn test case for qnn logistic

* Helper functions for quantize and dequantize.
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
…4696)

* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC

 * add qnn implementation
 * add qnn test case for qnn logistic

* Helper functions for quantize and dequantize.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: need update need update based on feedbacks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants