Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCKER] Add DGL to {ci_gpu, demo_cpu, demo_gpu} docker images #3692

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

yy665
Copy link
Contributor

@yy665 yy665 commented Aug 2, 2019

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

Add DGL (deep graph library) to CI and demo images.

Docker image built and tested on SAMPA cluster.

@@ -85,6 +85,9 @@ RUN bash /install/ubuntu_install_tflite.sh
COPY install/ubuntu_install_caffe2.sh /install/ubuntu_install_caffe2.sh
RUN bash /install/ubuntu_install_caffe2.sh

COPY install/ubuntu_install_dgl.sh /install/ubuntu_install_dgl.sh
RUN bash /install/ubuntu_install_dgl.sh

RUN pip3 install Pillow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just add dgl here?

Copy link
Contributor Author

@yy665 yy665 Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just trying to follow the existing convention of installing external frameworks.
FYI please see docker/install/ubuntu_install.mxnet.sh

@tqchen tqchen merged commit 163532b into apache:master Aug 2, 2019
@tqchen
Copy link
Member

tqchen commented Aug 2, 2019

Thanks @Yulun-Yao ! i will reply when the official docker get updated. will take a day or two

wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants