[docs] Add a tutorial for the pass manager #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anijain2305
reviewed
Jul 9, 2019
shoubhik
reviewed
Jul 9, 2019
weberlo
suggested changes
Jul 9, 2019
|
Awesome work! This tutorial seems very comprehensive and has already helped me understand the pass manager a lot more. I'll do another round of review at some point. |
merrymercy
reviewed
Jul 10, 2019
merrymercy
reviewed
Jul 10, 2019
slyubomirsky
requested changes
Jul 11, 2019
There was a problem hiding this comment.
Mostly some stylistic and grammar suggestions, and a couple of requests for clarification. Overall, I think this is a fairly thorough explanation of the pass manager and I am glad to see the extensive examples -- thank you very much for taking the time to write it all
|
@anijain2305 @weberlo @shoubhik @slyubomirsky @merrymercy Thanks for the reviews. I've addressed your comments. Please take another look when you have time. |
weberlo
suggested changes
Jul 12, 2019
slyubomirsky
approved these changes
Jul 16, 2019
Co-Authored-By: Steven S. Lyubomirsky <[email protected]>
Co-Authored-By: Steven S. Lyubomirsky <[email protected]>
Co-Authored-By: Steven S. Lyubomirsky <[email protected]>
Co-Authored-By: Steven S. Lyubomirsky <[email protected]>
Co-Authored-By: Steven S. Lyubomirsky <[email protected]>
|
@slyubomirsky Thanks a lot. @weberlo @shoubhik @anijain2305 @merrymercy Thank you all for the review. Please let me if you have any other comments or concerns. |
weberlo
suggested changes
Jul 16, 2019
Co-Authored-By: Logan Weber <[email protected]>
Co-Authored-By: Logan Weber <[email protected]>
weberlo
approved these changes
Jul 16, 2019
merrymercy
approved these changes
Jul 17, 2019
|
Thanks everyone, this is now merged. |
yzhliu
added
status: accepted
and removed
status: need update
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
* [docs] Add a tutorial for the pass manager * address comment * address more comments * retrigger ci * address steven's comments * address comments * retrigger ci * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Logan Weber <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Logan Weber <[email protected]>
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
* [docs] Add a tutorial for the pass manager * address comment * address more comments * retrigger ci * address steven's comments * address comments * retrigger ci * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Steven S. Lyubomirsky <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Logan Weber <[email protected]> * Update docs/dev/relay_pass_infra.rst Co-Authored-By: Logan Weber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3480
This PR adds a tutorial for the recently merged pass manager infra.
cc @tqchen @jroesch @weberlo @slyubomirsky @wweic @yongwww @yzhliu @icemelon9 @MarisaKirisame