Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count quota #678

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Count quota #678

merged 4 commits into from
Mar 17, 2023

Conversation

henrysun007
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

It is necessary to count the function invocation times. Almost every FaaS platform has this feature. A limit to the times is also added in this PR.

Fixes # (issue)

Type of change (select or add applied and delete the others)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just sync with upstream third-party crates

How has this been tested?

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

mssun
mssun previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@mssun mssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

AI-Memory
AI-Memory previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@AI-Memory AI-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

volcano0dr
volcano0dr reviewed Mar 17, 2023
View reviewed changes
sdk/rust/src/lib.rs Outdated Show resolved Hide resolved
@henrysun007 henrysun007 dismissed stale reviews from AI-Memory and mssun via c4bdcfe March 17, 2023 05:48
volcano0dr
volcano0dr reviewed Mar 17, 2023
View reviewed changes
services/proto/src/teaclave_frontend_service.rs Outdated Show resolved Hide resolved
services/proto/src/teaclave_frontend_service.rs Outdated Show resolved Hide resolved
services/proto/src/teaclave_frontend_service.rs Outdated Show resolved Hide resolved
services/proto/src/teaclave_frontend_service.rs Outdated Show resolved Hide resolved
@henrysun007 henrysun007 force-pushed the count-quota branch 2 times, most recently from 36c242e to a01868a Compare March 17, 2023 09:48
volcano0dr
volcano0dr approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@volcano0dr volcano0dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henrysun007 henrysun007 merged commit 37d8895 into apache:master Mar 17, 2023
@henrysun007 henrysun007 deleted the count-quota branch March 17, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volcano0dr volcano0dr volcano0dr approved these changes

@mssun mssun mssun left review comments

@AI-Memory AI-Memory AI-Memory left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrysun007 @mssun @AI-Memory @volcano0dr