Change the output formation of ToString method of Uuid

[ivila]

1. change the realization of Display trait of Uuid, make its formation
   const of 36 bytes.
2. introduce an env(RUN_TEST_IN_REE) in optee-utee-sys crate so that
   we can run library tests of optee-utee

This one relates to #151

[DemesneGH]

Acked-by: Yuan Zhuang <[email protected]>

[b49020]

@ivila care to update CI to run the library tests too?

[ivila]

@ivila care to update CI to run the library tests too?

@b49020 I have tried, the test of optee-utee can run succuessfully(because it links nothing when test), but for the test of optee-teec, it requires run on Arm machine (it requires to link the libteec, but on x86_64 machine it can not be done as we are not going to build a libteec.a of x86 architecture, check this pipeline).

And If I switch the pipeline to Arm64 runners I think it's a big change, shouldn't be include in this PR, that's why I finally give up.

But I can give it a try(hoping not change too much)

[DemesneGH]

@ivila Could you provide the cargo test command you use? Seems you have posted them on the original commit.

[b49020]

@ivila agree I think compiling and running tests on arm64 runners makes better sense. However, we should be able to compile native for x86 too for testing purposes. However, we should accumulate all the library tests under:

• optee-teec/systest
• optee-utee/systest

[b49020]

BTW, if you want to push actual fix separately, we should be able to merge it till we sort out how to run library tests.

[ivila]

@ivila Could you provide the cargo test command you use? Seems you have posted them on the original commit.

@DemesneGH Sure.

1. For optee-utee

the command is: (cd optee-utee && RUN_TEST_IN_REE=true cargo test --lib --features no_panic_handler --target aarch64-unknown-linux-gnu -vv)
need to set the env of RUN_TEST_IN_REE to true, and use the features of no_panic_handler, this can run successfully on x86 runner.

2. for optee-teec

the command is: (cd optee-teec && cargo test --lib --target aarch64-unknown-linux-gnu -vv)
this will failed as it wants to link teec (needs to run on Arm64 runner, and currently github not open this for OSS project, see this: [Make ARM64 Windows and Linux runner images available for free])

[ivila]

BTW, if you want to push actual fix separately, we should be able to merge it till we sort out how to run library tests.

@b49020 actually there is a quick fix way, just to provide an env to tell optee-teec-sys not to link the teec library (just like what I do at optee-utee-sys)

[ivila]

@ivila agree I think compiling and running tests on arm64 runners makes better sense. However, we should be able to compile native for x86 too for testing purposes. However, we should accumulate all the library tests under:

• optee-teec/systest
• optee-utee/systest

I think accumulate all the library tests is not a good idea for library unit tests, because you have to expose everything you want to test, for example, I have a function that just use in a module and actually I don't want to expose it, I have to make it pub if I want to accumulate it.

[b49020]

I think accumulate all the library tests is not a good idea for library unit tests,

Sounds reasonable from unit testing point of view.

[ivila]

@DemesneGH @b49020
Codes updated, the changes are:

1. change the env from RUN_TEST_IN_REE(true|false) to BUILD_TYPE(unit_test|any other value is default) for better understanding
2. provide this env to optee-teec-sys too
3. add unit test to ci, under build-utee-teec, and the pipeline result just check here
   

[b49020]

Reviewed-by: Sumit Garg <[email protected]>