-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-std] Add Documentation in README #128
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies I never got around to improving documentation due to other commitments. Apart from a minor comment changes looks good to me.
With that comment incorporated, feel free to add:
Reviewed-by: Sumit Garg <[email protected]>
Also, I suppose similar change should be applied to master
branch as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Sword-Destiny Could you give me a |
@b49020 Thanks for your comment. Sure, I will sync to Will also start the process for setting the |
Acked-by: Joakim Bech <[email protected]> Reviewed-by: Sumit Garg <[email protected]> Signed-off-by: Yuan Zhuang <[email protected]>
synced to |
No description provided.