Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-std] Add Documentation in README #128

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

DemesneGH
Copy link
Contributor

No description provided.

@jbech-linaro
Copy link
Contributor

Acked-by: Joakim Bech <[email protected]>

Copy link
Contributor

@b49020 b49020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I never got around to improving documentation due to other commitments. Apart from a minor comment changes looks good to me.

With that comment incorporated, feel free to add:

Reviewed-by: Sumit Garg <[email protected]>

Also, I suppose similar change should be applied to master branch as well.

README.md Outdated Show resolved Hide resolved
Copy link

@Sword-Destiny Sword-Destiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DemesneGH
Copy link
Contributor Author

@Sword-Destiny Could you give me a Reviewed-by tag like above? Thanks!

@DemesneGH
Copy link
Contributor Author

I suppose similar change should be applied to master branch as well.

@b49020 Thanks for your comment. Sure, I will sync to master after this PR merged.

Will also start the process for setting the default branch on the community.

Acked-by: Joakim Bech <[email protected]>
Reviewed-by: Sumit Garg <[email protected]>
Signed-off-by: Yuan Zhuang <[email protected]>
@DemesneGH DemesneGH merged commit 95d3767 into apache:no-std May 9, 2024
5 checks passed
@DemesneGH
Copy link
Contributor Author

synced to master: cd19ac2

@DemesneGH
Copy link
Contributor Author

@b49020 Could you help to review the new PR #131 (with some doc and ci changes)? thanks!
BTW seems I cannot mention(@) you in the PR you've not participated in, so send the comment here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants